Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: wheel bonuses #3058

Merged
merged 21 commits into from
Nov 13, 2024
Merged

fix: wheel bonuses #3058

merged 21 commits into from
Nov 13, 2024

Conversation

phacUFPE
Copy link
Contributor

@phacUFPE phacUFPE commented Nov 3, 2024

Description

This fixes all vocations wheel spell and gem bonuses, const references and refactors.

Behaviour

Actual

Some wheel spell and gem bonuses not working.

Expected

All wheel spell and gem bonuses working.

Fixes #3032

Fixes #2150

Fixes #2039

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested

  • Test the wheel with all vocations and bonuses

Test Configuration:

  • Server Version: Latest
  • Client: 13.40
  • Operating System: Windows 11

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I checked the PR checks reports
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works

@opentibiabr opentibiabr deleted a comment from jeswilldbm Nov 3, 2024
@phacUFPE phacUFPE marked this pull request as draft November 11, 2024 19:16
@phacUFPE phacUFPE marked this pull request as ready for review November 11, 2024 23:03
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
23.1% Duplication on New Code (required ≤ 10%)

See analysis details on SonarQube Cloud

@dudantas dudantas merged commit 1382b77 into main Nov 13, 2024
42 checks passed
@dudantas dudantas deleted the fix_wheel_bonuses branch November 13, 2024 01:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants